Skip to content

[Odometer] Image preview - #80532

Merged
Julesssss merged 42 commits into
Expensify:mainfrom
software-mansion-labs:jakubkalinski0/Odometer_Image_Preview
Feb 11, 2026
Merged

Julesssss merged 42 commits into
Expensify:mainfrom
software-mansion-labs:jakubkalinski0/Odometer_Image_Preview

Conversation

@jakubkalinski0

@jakubkalinski0 jakubkalinski0 commented Jan 26, 2026 •

Copy link
Copy Markdown
Member

Explanation of Change

This PR implements the “odometer image preview” portion of the odometer flow. The main goal is to let users tap the start/end image thumbnail and open a proper preview modal with replace/download/delete actions.

  • Navigation + route shape updates: Odometer image capture now carries reportID and uses imageType to match how receipt routes are composed (action/iouType segments).
ODOMETER_IMAGE: {
    route: ':action/:iouType/odometer-image/:transactionID/:reportID/:imageType',
    getRoute: (action: IOUAction, iouType: IOUType, transactionID: string, reportID: string, imageType: OdometerImageType) =>
        `${action as string}/${iouType as string}/odometer-image/${transactionID}/${reportID}/${imageType}` as const,
},
...
TRANSACTION_RECEIPT: {
    route: 'r/:reportID/transaction/:transactionID/receipt/:action?/:iouType?',
    getRoute: (reportID, transactionID, readonly = false, mergeTransactionID, imageType, action, iouType) => {
        const actionSegment = action ? `/${action}` : '';
        const iouTypeSegment = iouType ? `/${iouType}` : '';
        return `r/${reportID}/transaction/${transactionID}/receipt${actionSegment}${iouTypeSegment}?readonly=${readonly}${mergeTransactionID ? `&mergeTransactionID=${mergeTransactionID}` : ''}${imageType ? `&imageType=${imageType}` : ''}` as const;
    },
},
  • Odometer step now routes to preview instead of image capture when an image alreadexists. This keeps capture for empty state, and preview for populated state.
const handleViewOdometerImage = useCallback(
    (imageType: OdometerImageType) => {
        if (!reportID || !transactionID) {
            return;
        }
        Navigation.navigate(ROUTES.TRANSACTION_RECEIPT.getRoute(reportID, transactionID, false, undefined, imageType, action, iouType));
    },
    [reportID, transactionID, action, iouType],
);
...
onPress={() => {
    if (odometerStartImage) {
        handleViewOdometerImage(CONST.IOU.ODOMETER_IMAGE_TYPE.START);
    } else {
        handleCaptureImage(CONST.IOU.ODOMETER_IMAGE_TYPE.START);
    }
}}
  • Transaction receipt modal now supports odometer previews by reading imageType, selecting the appropriate local file, and exposing replace/delete actions with odometer‑specific copy. This lets users view, download, replace, or remove the start/end photo.
const {reportID, transactionID, action, iouType: iouTypeParam, readonly: readonlyParam, mergeTransactionID, imageType} = route.params;
...
const isOdometerImage = !!imageType;
let odometerImage: FileObject | string | undefined;
if (isOdometerImage) {
    odometerImage = imageType === CONST.IOU.ODOMETER_IMAGE_TYPE.START ? transaction?.comment?.odometerStartImage : transaction?.comment?.odometerEndImage;
}
...
const source = getImageSource();
...
if (isOdometerImage) {
    headerTitle = imageType === CONST.IOU.ODOMETER_IMAGE_TYPE.START ? translate('distance.odometer.startTitle') : translate('distance.odometer.endTitle');
} else {
    headerTitle = translate('common.receipt');
}
...
if (shouldShowReplaceReceiptButton || isOdometerImage) {
    Navigation.navigate(
        isOdometerImage
            ? ROUTES.ODOMETER_IMAGE.getRoute(action ?? CONST.IOU.ACTION.CREATE, iouType, transactionID, reportID, imageType)
            : ROUTES.MONEY_REQUEST_STEP_SCAN.getRoute(...),
    );
}
...
text: isOdometerImage ? translate('distance.odometer.deleteOdometerPhoto') : translate('receipt.deleteReceipt'),
prompt: isOdometerImage ? translate('distance.odometer.deleteOdometerPhotoConfirmation') : translate('receipt.deleteConfirmation'),
  • Translations: added odometer‑specific labels for preview titles and delete confirmation, and renamed the previous “start/end title” keys to “start/end photo title” to distinguish between screen titles vs. preview titles.

Fixed Issues

$ #77266
PROPOSAL: N/A

Tests

  1. Go to "FAB" -> press "Track distance" -> select the "Odometer" tab.
  2. Add start and end readings, then upload start odometer photo.
  3. Tap the start image thumbnail and verify the receipt modal opens with “Odometer start” title and the correct image displayed.
  4. Tap "Download" and verify that the image was downloaded properly.
  5. Tap “Replace” and verify it navigates to the odometer image capture screen, then select a new file and verify the thumbnail updates properly without anything missing.
  6. Tap “Delete odometer photo” and confirm that the image was properly deleted -> the preview should close + verify the thumbnail clears properly without anything missing.
  7. Repeat steps 3–6 for the end image.
  • Verify that no errors appear in the JS console

Offline tests

  1. Turn off network.
  2. Repeat all steps from the Tests section and verify that everything works same as in Tests

QA Steps

Same as Tests, this feature requires the odometerExpenses beta -- let @Julesssss know if you have any problems here

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

MacOS: Chrome / Safari

online:

online1.mp4

offline:

offline1.mp4

@melvin-bot

melvin-bot Bot commented Jan 26, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@jakubkalinski0

Copy link
Copy Markdown
Member Author

@shawnborton While I am waiting for merge on the previous PR I'm polishing this one for review. Any remarks on the image preview here?

output.mp4

@shawnborton

Copy link
Copy Markdown
Contributor

Only minor feedback I have is that I think we can simplify the modal titles to simply say "Odometer start" instead of "Odometer start photo". Same with "Odometer end"

Thoughts @Expensify/design @jamesdeanexpensify ?

@shawnborton

Copy link
Copy Markdown
Contributor

The UI looks correct though.

@dannymcclain

Copy link
Copy Markdown
Contributor

Yup—looking pretty good to me. Agree with your copy edits!

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

This sounds good to me!

@jakubkalinski0

Copy link
Copy Markdown
Member Author

Done!

Screen.Recording.2026-02-10.at.19.18.09.mov

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

Dang, actually sorry, can we add the photo back in? Seeing it in context, I think making it as obvious as possible (at least to start) is a good idea in this particular situation. Sorry about that one.

@jakubkalinski0

Copy link
Copy Markdown
Member Author

Well the question is where do we want this "Odometer start/end photo" version and where the version without the "photo"? The initial design in Figma includes “photo” wherever that term appears, but Shawn wanted it removed in modal titles here, and I am not sure if we want to have different terms in different places or do we want it to be consistent across all usages.

@jamesdeanexpensify @shawnborton

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

If you don't mind @shawnborton - are you cool including photo for now everywhere? I changed my mind.

@shawnborton

Copy link
Copy Markdown
Contributor

That's fine by me! Figured we might be able to tighten it up a bit but happy to keep it there.

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

Thank you sir!

Comment thread src/ROUTES.ts Resolved
});
}

function revokeOdometerImageUri(image: FileObject | string | null | undefined, nextImage?: FileObject | string | null): void {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jakubkalinski0 If this is necessary, I think we might already have a similar function somewhere in the codebase. Could you see how we did in receipts in the manual request flow?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will look into it

@jakubkalinski0 jakubkalinski0 Feb 11, 2026 •

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the manual request flow and couldn’t find an existing shared helper for this. In receipts we create blob URLs in the step components and store them via setMoneyRequestReceipt but we don’t centrally revoke them on replace/remove (setMoneyRequestReceipt, removeTransactionReceipt and detachReceipt only update Onyx). So this revokeOdometerImageUri helper is new behavior not a duplicate of an existing utility.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming. I'm going to move forward here and we can discuss further in our dm chat if @DylanDylann has a further thought here.

@DylanDylann

Copy link
Copy Markdown
Contributor

Tested and works well

@Julesssss Julesssss changed the title [NO QA] [Odometer] Image preview [Odometer] Image preview Feb 11, 2026
@Julesssss

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@Julesssss
Julesssss merged commit 9c943c1 into Expensify:main Feb 11, 2026
32 of 34 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.3.18-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@lanitochka17

Copy link
Copy Markdown

This PR is failing because of issue ##82327

The issue is reproducible in: Android IOS

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.3.18-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants